SQL

Hi there I have this query:

 return (from dev in uow.Developers
              from addIn in dev.AddIns
              where
                (
                  string.IsNullOrEmpty(SearchForDeveloperName)
                  ||
                  LikeOperator.LikeString(dev.Name, SearchForDeveloperName, CompareMethod.Text)
                )
                &&
                (
**              string.IsNullOrEmpty(SearchForAddInName)  
**              ||                                                        
                  LikeOperator.LikeString(addIn.Name, SearchForAddInName, CompareMethod.Text)
                )
              select
                dev
             );

I get an SQL exception:

"In der Nähe von 'OR' wurde ein nicht boolescher Ausdruck in einem Kontext angegeben, in dem eine Bedingung erwartet wird."

Near to the "OR" a not boolean term was defined within a context that expected a condition.

If I comment out the two marked (**) lines the error disappears - but the sql query is not what I want.

Both, SearchForDeveloperName and SearchForAddInName = string.Empty;

Any ideas?

We had an issue with && expressions where the first element was a constant True and the second element was a complex clause containing another boolean constant (in your case, another True).  There will be a fix in the next nightly build.

As an interim workaround, you might be able eliminate the || expressions by resolving empty strings to wildcards:

string dn = String.IsNullOrEmpty(DevName) ? "*" : DevName;

... where LikeOperator.LikeString(dev.Name, dn, CompareMethod.Text) && ...

Haven't tried this though.

That was fast - thanks Ivan!

Sure, in terms of valid SQL your interim solution is right - in terms of performance it is not optimal.

Just installed the current version. Since I needed to modify the base entity I downloaded the source and apply my changes.

Now I didn't get even where clause?!

====================================================================

 var q = (from dev in uow.Developers
              from addIn in dev.AddIns
              where
                (
                  string.IsNullOrEmpty(SearchForDeveloperName)
                  ||
                  LikeOperator.LikeString(dev.Name, SearchForDeveloperName, CompareMethod.Text)
                )
                &&
                (
                  string.IsNullOrEmpty(SearchForAddInName)
                  ||
                  LikeOperator.LikeString(addIn.Name, SearchForAddInName, CompareMethod.Text)
                )
              select
                dev
             );

      foreach (Developer developer in q)
      {
        string name = developer.Name;
      }

====================================================================

SELECT
  t0.Id AS [t0.Id],
  t0.AuditChangedAt AS [t0.AuditChangedAt],
  t0.AuditCreatedAt AS [t0.AuditCreatedAt],
  t0.LockVersion AS [t0.LockVersion],
  t1.Id AS [t1.Id],
  t1.AuditChangedAt AS [t1.AuditChangedAt],
  t1.AuditCreatedAt AS [t1.AuditCreatedAt],
  t1.DeveloperId AS [t1.DeveloperId],
  t1.IsInTestMode AS [t1.IsInTestMode],
  t1.LockVersion AS [t1.LockVersion],
  t1.Name AS [t1.Name],
  t1.PadFileErrorCounterSinceLastUpdate AS [t1.PadFileErrorCounterSinceLastUpdate],
  t1.PadFileErrorMessage AS [t1.PadFileErrorMessage],
  t1.PadFileLastUpdate AS [t1.PadFileLastUpdate],
  t1.PadFileUrl AS [t1.PadFileUrl],
  t1.UsePadFile AS [t1.UsePadFile]
FROM
  Developer t0
INNER JOIN
  AddIn t1
ON
  t0.Id = t1.DeveloperId

--> Time:   1 ms

====================================================================

Modified source:

using System;
using System.ComponentModel;
using System.Xml.Serialization;

namespace Mindscape.LightSpeed
{

  public abstract partial class Entity<TId> : Entity
  {
    #region Const, Fields, Properties & Events

    [NonSerialized]
    private static readonly object _tempIdLock = new object();
    [NonSerialized]
    private static int _currentTempIdValue;
    [Transient]
    private int? _tempId;

    /// <summary>
    ///
    /// </summary>
    ///
    [Browsable(false)]
    [XmlIgnore]
    public int TempId
    {
      get
      {
        if (_tempId == null)
        {
          _tempId = createNextTempId();
        }
        return _tempId.Value;
      }
    }

    #endregion

    #region Methods

    private static int createNextTempId()
    {
      lock (_tempIdLock)
      {
        return --_currentTempIdValue;
      }
    }

    #endregion
  }
}

Any Ideas?

Correct.  As you said in the original message, both of your SearchForXxx strings are empty.  Therefore both String.IsNullOrEmpty calls return true.  Therefore both ||-expressions are true.  Therefore the &&-expression is true.  Therefore the query is going to return all results.  Therefore there is no WHERE clause.

Huh - I didn't expected that LS is smart enough to do such pre-evaluations.

Thanks for the clarification!